Fix paths for enabled scripts in ExprScripts. #6374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
bug
APickledWalrus
approved these changes
Feb 1, 2024
UnderscoreTud
approved these changes
Feb 1, 2024
sovdeeth
added
the
patch-ready
ShaneBeee
pushed a commit
to ShaneBeee/Skript
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disabled scripts are stored as files with relative paths, so the code works perfectly already.
Enabled scripts are Configs with Paths created by File#toPath(), so ExprScripts converts them back into Files with Path#toFile(). This creates a File with an absolute path, not relative.
This fix relativizes the paths of all the scripts to the scripts folder.
There's an existing issue of accuracy in the disabled scripts that will be handled in another PR.
Target Minecraft Versions: any
Requirements: none
Related Issues: #6373